fix(kanban): do not set filter by default

This fixes a bug where, upon updating a bucket, it would set a default filter of done = false (which is the default filter for the list view), coming from the model.

Partially resolves https://community.vikunja.io/t/bugs-around-project-duplication-with-kanban-buckets/3433/3

frontend/src/modelTypes/IProjectView.ts

@@ -30,7 +30,7 @@ export interface IProjectView extends IAbstract {
 	projectId: IProject['id']
 	viewKind: ProjectViewKind
 
-	filter: IFilters
+	filter: IFilters|undefined
 	position: number
 
 	bucketConfigurationMode: ProjectViewBucketConfigurationMode

frontend/src/models/projectView.ts

@@ -8,9 +8,9 @@ export default class ProjectViewModel extends AbstractModel<IProjectView> implem
 	viewKind: ProjectViewKind =  'list'
 
 	filter: IProjectView['filters'] = {
-		sort_by: ['done', 'id'],
-		order_by: ['asc', 'desc'],
-		filter: 'done = false',
+		sort_by: [],
+		order_by: [],
+		filter: '',
 		filter_include_nulls: true,
 		s: '',
 	}
@@ -32,4 +32,18 @@ export default class ProjectViewModel extends AbstractModel<IProjectView> implem
 			this.bucketConfiguration = []
 		}
 	}
+
+	static createWithDefaultFilter(data: Partial<IProjectView> = {}): ProjectViewModel {
+		const defaultFilter: IProjectView['filters'] = {
+			sort_by: ['done', 'id'],
+			order_by: ['asc', 'desc'],
+			filter: 'done = false',
+			filter_include_nulls: true,
+			s: '',
+		}
+
+		const instance = new ProjectViewModel(data)
+		instance.filter = defaultFilter
+		return instance
+	}
 }

frontend/src/views/project/settings/ProjectSettingsViews.vue

@@ -38,7 +38,7 @@ watch(
 const showCreateForm = ref(false)
 
 const projectViewService = shallowReactive(new ProjectViewService())
-const newView = ref<IProjectView>(new ProjectViewModel({}))
+const newView = ref<IProjectView>(ProjectViewModel.createWithDefaultFilter())
 const viewIdToDelete = ref<number | null>(null)
 const showDeleteModal = ref(false)
 const viewToEdit = ref<IProjectView | null>(null)