From 1e1fcaafbc06fffee0af775ddb47465f54c1f826 Mon Sep 17 00:00:00 2001 From: kolaente Date: Wed, 27 May 2026 17:35:58 +0200 Subject: [PATCH] fix(ci): drop "./" from PACKAGE_OUTPUT_DIR so strip-path-prefix matches The s3-action expands the upload glob into paths without a leading "./", but strip-path-prefix was set to "./dist/os-packages/" (or "./veans/dist/os-packages/"). The prefix never matched, so packages landed at ////dist/os-packages/ instead of ///. Drop the "./" prefix to match the working DIST_PREFIX pattern in release-binaries. --- .github/actions/release-os-package/action.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/actions/release-os-package/action.yml b/.github/actions/release-os-package/action.yml index bd205f211..ad71b5354 100644 --- a/.github/actions/release-os-package/action.yml +++ b/.github/actions/release-os-package/action.yml @@ -66,14 +66,16 @@ runs: echo "STAGED_BINARY_PATH=./vikunja" >> "$GITHUB_ENV" echo "NFPM_BIN_PATH=" >> "$GITHUB_ENV" echo "NFPM_CONFIG_PATH=./nfpm.yaml" >> "$GITHUB_ENV" - echo "PACKAGE_OUTPUT_DIR=./dist/os-packages" >> "$GITHUB_ENV" + # No leading "./" — the s3-action's strip-path-prefix must + # match the glob output exactly, and the glob doesn't emit it. + echo "PACKAGE_OUTPUT_DIR=dist/os-packages" >> "$GITHUB_ENV" ;; veans) echo "BINARIES_DOWNLOAD_PATH=./veans-binaries" >> "$GITHUB_ENV" echo "STAGED_BINARY_PATH=./veans/veans-bin" >> "$GITHUB_ENV" echo "NFPM_BIN_PATH=./veans/veans-bin" >> "$GITHUB_ENV" echo "NFPM_CONFIG_PATH=./veans/nfpm.yaml" >> "$GITHUB_ENV" - echo "PACKAGE_OUTPUT_DIR=./veans/dist/os-packages" >> "$GITHUB_ENV" + echo "PACKAGE_OUTPUT_DIR=veans/dist/os-packages" >> "$GITHUB_ENV" ;; *) echo "::error::unknown project '$PROJECT' (expected vikunja|veans)"