From 1fac81c8deaf3b324dcdbd053db8dc53a12738ca Mon Sep 17 00:00:00 2001 From: kolaente Date: Thu, 31 Oct 2024 19:19:56 +0100 Subject: [PATCH] feat(cli): add cli command to delete orphan task positions --- pkg/cmd/maintenance.go | 56 +++++++++++++++++++++++++++++++++++++ pkg/models/task_position.go | 6 ++++ 2 files changed, 62 insertions(+) create mode 100644 pkg/cmd/maintenance.go diff --git a/pkg/cmd/maintenance.go b/pkg/cmd/maintenance.go new file mode 100644 index 000000000..6f04bc7a5 --- /dev/null +++ b/pkg/cmd/maintenance.go @@ -0,0 +1,56 @@ +// Vikunja is a to-do list application to facilitate your life. +// Copyright 2018-present Vikunja and contributors. All rights reserved. +// +// This program is free software: you can redistribute it and/or modify +// it under the terms of the GNU Affero General Public Licensee as published by +// the Free Software Foundation, either version 3 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU Affero General Public Licensee for more details. +// +// You should have received a copy of the GNU Affero General Public Licensee +// along with this program. If not, see . + +package cmd + +import ( + "code.vikunja.io/api/pkg/db" + "code.vikunja.io/api/pkg/initialize" + "code.vikunja.io/api/pkg/log" + "code.vikunja.io/api/pkg/models" + + "github.com/spf13/cobra" +) + +func init() { + rootCmd.AddCommand(deleteOrphanTaskPositions) +} + +var deleteOrphanTaskPositions = &cobra.Command{ + Use: "delete-orphan-task-positions", + Short: "Removes all task positions for tasks or project views which don't exist anymore.", + PreRun: func(_ *cobra.Command, _ []string) { + initialize.FullInitWithoutAsync() + }, + Run: func(_ *cobra.Command, _ []string) { + + s := db.NewSession() + defer s.Close() + + count, err := models.DeleteOrphanedTaskPositions(s) + if err != nil { + log.Errorf("Could not delete orphaned task positions: %s", err) + return + } + + if count == 0 { + log.Infof("No orphaned task positions found.") + return + } + + log.Infof("Successfully deleted %d orphaned task positions.", count) + }, +} diff --git a/pkg/models/task_position.go b/pkg/models/task_position.go index 02b61165c..a895c6a26 100644 --- a/pkg/models/task_position.go +++ b/pkg/models/task_position.go @@ -242,3 +242,9 @@ func calculateNewPositionForTask(s *xorm.Session, a web.Auth, t *Task, view *Pro Position: calculateDefaultPosition(t.Index, t.Position), }, nil } + +func DeleteOrphanedTaskPositions(s *xorm.Session) (count int64, err error) { + return s. + Where("task_id not in (select id from tasks) OR project_view_id not in (select id from project_views)"). + Delete(&TaskPosition{}) +}