From 357dbc1c693b90132d2b12caaa1e6dd0f6bcd1aa Mon Sep 17 00:00:00 2001
From: Leonardo Cossutta <leonardo.cossutta@gmail.com>
Date: Wed, 19 Mar 2025 12:56:19 +0000
Subject: [PATCH] feat(labels): show priority labels based on minimum priority
 setting (#3075)

I think showing the priority of a task regardless of its value can be useful, the option for the user to choose the minimum priority for visualization is exposed in the settings. The default value is `priority.HIGH`, that corresponds to the current behavior.

Co-authored-by: konrad <k@knt.li>
Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/3075
Reviewed-by: konrad <k@knt.li>
Co-authored-by: Leonardo Cossutta <leonardo.cossutta@gmail.com>
Co-committed-by: Leonardo Cossutta <leonardo.cossutta@gmail.com>
---
 frontend/src/components/misc/Icon.ts          |  2 ++
 .../tasks/partials/PriorityLabel.vue          | 31 ++++++++++++++-----
 frontend/src/i18n/lang/en.json                |  1 +
 frontend/src/modelTypes/IUserSettings.ts      |  4 ++-
 frontend/src/models/userSettings.ts           |  2 ++
 frontend/src/views/user/settings/General.vue  | 27 ++++++++++++++++
 6 files changed, 59 insertions(+), 8 deletions(-)

diff --git a/frontend/src/components/misc/Icon.ts b/frontend/src/components/misc/Icon.ts
index ebd9ce7cd..f248e1a33 100644
--- a/frontend/src/components/misc/Icon.ts
+++ b/frontend/src/components/misc/Icon.ts
@@ -28,6 +28,7 @@ import {
 	faDownload,
 	faEllipsisH,
 	faEllipsisV,
+	faExclamation,
 	faExclamationCircle,
 	faEye,
 	faEyeSlash,
@@ -193,6 +194,7 @@ library.add(faFont)
 library.add(faRulerHorizontal)
 library.add(faUnderline)
 library.add(faFaceLaugh)
+library.add(faExclamation)
 
 // overwriting the wrong types
 export default FontAwesomeIcon as unknown as FontAwesomeIconFixedTypes
\ No newline at end of file
diff --git a/frontend/src/components/tasks/partials/PriorityLabel.vue b/frontend/src/components/tasks/partials/PriorityLabel.vue
index d1f1ccdf9..894af1aa7 100644
--- a/frontend/src/components/tasks/partials/PriorityLabel.vue
+++ b/frontend/src/components/tasks/partials/PriorityLabel.vue
@@ -1,17 +1,22 @@
 <template>
 	<span
-		v-if="!done && (showAll || priority >= priorities.HIGH)"
+		v-if="!done && (showAll || priority >= minimumPriority)"
 		:class="{
-			'not-so-high': priority === priorities.HIGH,
+			'negligible': priority <= priorities.LOW,
+			'not-so-high': priority > priorities.LOW && priority < priorities.HIGH,
 			'high-priority': priority >= priorities.HIGH
 		}"
 		class="priority-label"
 	>
-		<span
-			v-if="priority >= priorities.HIGH"
-			class="icon"
-		>
-			<Icon icon="exclamation-circle" />
+		<span class="icon">
+			<Icon
+				v-if="priority >= priorities.HIGH"
+				icon="exclamation-circle"
+			/>
+			<Icon
+				v-else
+				icon="exclamation"
+			/>
 		</span>
 		<span>
 			<template v-if="priority === priorities.UNSET">{{ $t('task.priority.unset') }}</template>
@@ -25,7 +30,9 @@
 </template>
 
 <script setup lang="ts">
+import {computed} from 'vue'
 import {PRIORITIES as priorities} from '@/constants/priorities'
+import {useAuthStore} from '@/stores/auth'
 	
 withDefaults(defineProps<{
 	priority: number,
@@ -36,6 +43,12 @@ withDefaults(defineProps<{
 	showAll: false,
 	done: false,
 })
+
+const authStore = useAuthStore()
+
+const minimumPriority = computed(() => {
+	return authStore.settings.frontendSettings.minimumPriority
+})
 </script>
 
 <style lang="scss" scoped>
@@ -48,6 +61,10 @@ withDefaults(defineProps<{
 	color: var(--warning);
 }
 
+.negligible {
+	color: var(--info);
+}
+
 .icon {
 	vertical-align: top;
 	width: auto !important;
diff --git a/frontend/src/i18n/lang/en.json b/frontend/src/i18n/lang/en.json
index 69c654c72..0b1df19af 100644
--- a/frontend/src/i18n/lang/en.json
+++ b/frontend/src/i18n/lang/en.json
@@ -100,6 +100,7 @@
         "timezone": "Time zone",
         "overdueTasksRemindersTime": "Overdue tasks reminder email time",
         "filterUsedOnOverview": "Saved filter used on the overview page",
+        "minimumPriority": "Minimum visible task priority",
         "externalUserNameChange": "Your name is managed by your login provider ({provider}). To change it, please update it there instead."
       },
       "totp": {
diff --git a/frontend/src/modelTypes/IUserSettings.ts b/frontend/src/modelTypes/IUserSettings.ts
index 0ca266288..104515323 100644
--- a/frontend/src/modelTypes/IUserSettings.ts
+++ b/frontend/src/modelTypes/IUserSettings.ts
@@ -5,6 +5,7 @@ import type {PrefixMode} from '@/modules/parseTaskText'
 import type {BasicColorSchema} from '@vueuse/core'
 import type {SupportedLocale} from '@/i18n'
 import type {DefaultProjectViewKind} from '@/modelTypes/IProjectView'
+import type {Priority} from '@/constants/priorities'
 
 export interface IFrontendSettings {
 	playSoundWhenDone: boolean
@@ -12,6 +13,7 @@ export interface IFrontendSettings {
 	colorSchema: BasicColorSchema
 	filterIdUsedOnOverview: IProject['id'] | null
 	defaultView?: DefaultProjectViewKind
+	minimumPriority: Priority
 }
 
 export interface IUserSettings extends IAbstract {
@@ -20,7 +22,7 @@ export interface IUserSettings extends IAbstract {
 	discoverableByName: boolean
 	discoverableByEmail: boolean
 	overdueTasksRemindersEnabled: boolean
-	overdueTasksRemindersTime: string | Date
+	overdueTasksRemindersTime: undefined | string | Date
 	defaultProjectId: undefined | IProject['id']
 	weekStart: 0 | 1 | 2 | 3 | 4 | 5 | 6
 	timezone: string
diff --git a/frontend/src/models/userSettings.ts b/frontend/src/models/userSettings.ts
index 31ec7b745..9b791a0a4 100644
--- a/frontend/src/models/userSettings.ts
+++ b/frontend/src/models/userSettings.ts
@@ -4,6 +4,7 @@ import type {IFrontendSettings, IUserSettings} from '@/modelTypes/IUserSettings'
 import {getBrowserLanguage} from '@/i18n'
 import {PrefixMode} from '@/modules/parseTaskText'
 import {DEFAULT_PROJECT_VIEW_SETTINGS} from '@/modelTypes/IProjectView'
+import {PRIORITIES} from '@/constants/priorities'
 
 export default class UserSettingsModel extends AbstractModel<IUserSettings> implements IUserSettings {
 	name = ''
@@ -21,6 +22,7 @@ export default class UserSettingsModel extends AbstractModel<IUserSettings> impl
 		quickAddMagicMode: PrefixMode.Default,
 		colorSchema: 'auto',
 		defaultView: DEFAULT_PROJECT_VIEW_SETTINGS.FIRST,
+		minimumPriority: PRIORITIES.HIGH,
 	}
 
 	constructor(data: Partial<IUserSettings> = {}) {
diff --git a/frontend/src/views/user/settings/General.vue b/frontend/src/views/user/settings/General.vue
index b59718152..35690d065 100644
--- a/frontend/src/views/user/settings/General.vue
+++ b/frontend/src/views/user/settings/General.vue
@@ -51,6 +51,30 @@
 				</select>
 			</div>
 		</div>
+		<div class="field">
+			<label class="label">
+				{{ $t('user.settings.general.minimumPriority') }}
+			</label>
+			<div class="select">
+				<select v-model="settings.frontendSettings.minimumPriority">
+					<option :value="PRIORITIES.LOW">
+						{{ $t('task.priority.low') }}
+					</option>
+					<option :value="PRIORITIES.MEDIUM">
+						{{ $t('task.priority.medium') }}
+					</option>
+					<option :value="PRIORITIES.HIGH">
+						{{ $t('task.priority.high') }}
+					</option>
+					<option :value="PRIORITIES.URGENT">
+						{{ $t('task.priority.urgent') }}
+					</option>
+					<option :value="PRIORITIES.DO_NOW">
+						{{ $t('task.priority.doNow') }}
+					</option>
+				</select>
+			</div>
+		</div>
 		<div
 			v-if="hasFilters"
 			class="field"
@@ -247,6 +271,7 @@ import {useAuthStore} from '@/stores/auth'
 import type {IUserSettings} from '@/modelTypes/IUserSettings'
 import {isSavedFilter} from '@/services/savedFilter'
 import {DEFAULT_PROJECT_VIEW_SETTINGS} from '@/modelTypes/IProjectView'
+import {PRIORITIES} from '@/constants/priorities'
 
 const {t} = useI18n({useScope: 'global'})
 useTitle(() => `${t('user.settings.general.title')} - ${t('user.settings.title')}`)
@@ -288,6 +313,8 @@ const settings = ref<IUserSettings>({
 		...authStore.settings.frontendSettings,
 		// Add fallback for old settings that don't have the default view set
 		defaultView: authStore.settings.frontendSettings.defaultView ?? DEFAULT_PROJECT_VIEW_SETTINGS.FIRST,
+		// Add fallback for old settings that don't have the minimum priority set
+		minimumPriority: authStore.settings.frontendSettings.minimumPriority ?? PRIORITIES.HIGH,
 	},
 })
 const id = ref(createRandomID())