From 37a34cc5cf04a80a3d37b6e193c3c473a9b866ff Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Wed, 17 Jun 2026 22:49:21 +0200
Subject: [PATCH] fix(notifications): log unexpected user refresh failures

A transient database error while reloading a notification's user was
swallowed silently, leaving stale names with no trace. Log everything
except the expected "user was deleted" case.
---
 pkg/models/notifications_refresh.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pkg/models/notifications_refresh.go b/pkg/models/notifications_refresh.go
index 17af513f6..cc119aeae 100644
--- a/pkg/models/notifications_refresh.go
+++ b/pkg/models/notifications_refresh.go
@@ -94,6 +94,9 @@ func refreshUser(s *xorm.Session, u *user.User, cache map[int64]*user.User) {
 	if !cached {
 		loaded, err := user.GetUserByID(s, u.ID)
 		if err != nil && !user.IsErrUserStatusError(err) {
+			if !user.IsErrUserDoesNotExist(err) {
+				log.Errorf("Could not refresh user %d for a notification: %v", u.ID, err)
+			}
 			cache[u.ID] = nil
 			return
 		}