kodev-org
/
vikunja
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(webhook): return error from sendWebhookPayload on non-2xx responses 

Previously the HTTP response status was only logged, so retries never
triggered for failing webhooks and downstream fan-out bugs (#2569) were
impossible to exercise via tests. Returning an error lets the watermill
retry middleware do its job.
This commit is contained in:
kolaente 2026-04-09 10:06:53 +02:00 committed by kolaente
parent 4415485675
commit 42b0f0ba77
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/models/webhooks.go
View File

@ -24,6 +24,7 @@ import (
"encoding/base64"
"encoding/hex"
"encoding/json"
"fmt"
"io"
"net/http"
"sort"
@ -337,12 +338,13 @@ func (w *Webhook) sendWebhookPayload(p *WebhookPayload) (err error) {
defer res.Body.Close()
if res.StatusCode > 399 {
responseBody, err := io.ReadAll(res.Body)
if err != nil {
return err
responseBody, readErr := io.ReadAll(res.Body)
if readErr != nil {
return fmt.Errorf("webhook %d returned status %d and reading its body failed: %w", w.ID, res.StatusCode, readErr)
}
log.Errorf("Got response with status %d from webhook %d: %s", res.StatusCode, w.ID, responseBody)
return fmt.Errorf("webhook %d returned non-success status %d", w.ID, res.StatusCode)
}
log.Debugf("Sent webhook payload for webhook %d for event %s", w.ID, p.EventName)