kodev-org
/
vikunja
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(frontend): origUrlToCheck references the same object as urlToCheck 

When later `urlToCheck` is restored in catch blocks, `origUrlToCheck`
will already be mutated.

Fixed by storing the original pathname as a string copy instead of
keeping a reference to the same URL object.
This commit is contained in:
MidoriKurage 2026-03-22 11:40:25 +08:00 committed by kolaente
parent 212968cec4
commit 4dd18e379e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/helpers/checkAndSetApiUrl.ts
View File

@ -46,7 +46,7 @@ export const checkAndSetApiUrl = (pUrl: string | undefined | null): Promise<stri
throw new InvalidApiUrlProvidedError()
}
const origUrlToCheck = urlToCheck
const origPathname = urlToCheck.pathname
const oldUrl = window.API_URL
window.API_URL = urlToCheck.toString()
@ -70,7 +70,7 @@ export const checkAndSetApiUrl = (pUrl: string | undefined | null): Promise<stri
})
.catch(e => {
// Check if it is reachable at /api/v1 and https
urlToCheck.pathname = origUrlToCheck.pathname
urlToCheck.pathname = origPathname
if (
!urlToCheck.pathname.endsWith('/api/v1') &&
!urlToCheck.pathname.endsWith('/api/v1/')
@ -92,7 +92,7 @@ export const checkAndSetApiUrl = (pUrl: string | undefined | null): Promise<stri
})
.catch(e => {
// Check if it is reachable at :API_DEFAULT_PORT and /api/v1
urlToCheck.pathname = origUrlToCheck.pathname
urlToCheck.pathname = origPathname
if (
!urlToCheck.pathname.endsWith('/api/v1') &&
!urlToCheck.pathname.endsWith('/api/v1/')