From 522f1cb5962482773cacfaa3a2b23c01d326d944 Mon Sep 17 00:00:00 2001
From: Dominik Pschenitschni <mail@celement.de>
Date: Sun, 26 Jan 2025 21:27:32 +0100
Subject: [PATCH] feat: arm 'vue/no-setup-props-reactivity-loss' rule

---
 frontend/eslint.config.js                            | 2 +-
 frontend/src/components/input/Password.vue           | 1 +
 frontend/src/components/misc/Popup.vue               | 1 +
 frontend/src/components/misc/flatpickr/Flatpickr.vue | 1 +
 frontend/vite.config.ts                              | 6 +-----
 5 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/frontend/eslint.config.js b/frontend/eslint.config.js
index f0da7af56..ee69d487d 100644
--- a/frontend/eslint.config.js
+++ b/frontend/eslint.config.js
@@ -48,7 +48,7 @@ export default [
 
 			// vue3
 			'vue/no-ref-object-reactivity-loss': 'error',
-			'vue/no-setup-props-reactivity-loss': 'warn', // TODO: switch to error after vite `propsDestructure` is removed
+			'vue/no-setup-props-reactivity-loss': 'error',
 
 			'@typescript-eslint/no-unused-vars': [
 				'error',
diff --git a/frontend/src/components/input/Password.vue b/frontend/src/components/input/Password.vue
index 9b490d3da..f9b4f5936 100644
--- a/frontend/src/components/input/Password.vue
+++ b/frontend/src/components/input/Password.vue
@@ -55,6 +55,7 @@ const emit = defineEmits<{
 const {t} = useI18n()
 const passwordFieldType = ref('password')
 const password = ref('')
+// eslint-disable-next-line vue/no-setup-props-reactivity-loss
 const isValid = ref<true | string>(props.validateInitially === true ? true : '')
 const validateAfterFirst = ref(false)
 
diff --git a/frontend/src/components/misc/Popup.vue b/frontend/src/components/misc/Popup.vue
index 6f9c75973..3f8601563 100644
--- a/frontend/src/components/misc/Popup.vue
+++ b/frontend/src/components/misc/Popup.vue
@@ -51,6 +51,7 @@ defineSlots<{
 	}): void
 }>()
 
+// eslint-disable-next-line vue/no-setup-props-reactivity-loss
 const openValue = ref(props.open)
 watchEffect(() => {
 	openValue.value = props.open
diff --git a/frontend/src/components/misc/flatpickr/Flatpickr.vue b/frontend/src/components/misc/flatpickr/Flatpickr.vue
index dec139cdb..8d6822925 100644
--- a/frontend/src/components/misc/flatpickr/Flatpickr.vue
+++ b/frontend/src/components/misc/flatpickr/Flatpickr.vue
@@ -93,6 +93,7 @@ const attrs = useAttrs()
 
 const root = ref<HTMLInputElement | null>(null)
 const fp = ref<flatpickr.Instance | null>(null)
+// eslint-disable-next-line vue/no-setup-props-reactivity-loss
 const safeConfig = ref<Options>({...props.config})
 
 function prepareConfig() {
diff --git a/frontend/vite.config.ts b/frontend/vite.config.ts
index c73fa3cef..66e97c7ed 100644
--- a/frontend/vite.config.ts
+++ b/frontend/vite.config.ts
@@ -100,11 +100,7 @@ export default defineConfig(({mode}) => {
 			},
 		},
 		plugins: [
-			vue({
-				script: {
-					propsDestructure: true,
-				},
-			}),
+			vue(),
 			svgLoader({
 				// Since the svgs are already manually optimized via https://jakearchibald.github.io/svgomg/
 				// we don't need to optimize them again.