fix(kanban): correctly set default bucket id when duplicating project

Partially resolves https://community.vikunja.io/t/bugs-around-project-duplication-with-kanban-buckets/3433

pkg/db/fixtures/project_views.yml

@@ -24,6 +24,7 @@
   updated: '2024-03-18 15:14:13'
   created: '2018-03-18 15:14:13'
   bucket_configuration_mode: 1
+  default_bucket_id: 1
 - id: 5
   title: List
   project_id: 2

pkg/models/project_duplicate.go

@@ -21,6 +21,7 @@ import (
 	"code.vikunja.io/api/pkg/log"
 	"code.vikunja.io/api/pkg/utils"
 	"code.vikunja.io/api/pkg/web"
+
 	"xorm.io/xorm"
 )
 
@@ -217,8 +218,14 @@ func duplicateViews(s *xorm.Session, pd *ProjectDuplicate, doer web.Auth, taskMa
 	}
 
 	for _, view := range views {
+		if view.DefaultBucketID != 0 {
+			view.DefaultBucketID = bucketMap[view.DefaultBucketID]
+		}
 		if view.DoneBucketID != 0 {
 			view.DoneBucketID = bucketMap[view.DoneBucketID]
+		}
+
+		if view.DefaultBucketID != 0 || view.DoneBucketID != 0 {
 			err = view.Update(s, doer)
 			if err != nil {
 				return err

pkg/models/project_duplicate_test.go

@@ -17,6 +17,7 @@
 package models
 
 import (
+	"fmt"
 	"testing"
 
 	"code.vikunja.io/api/pkg/db"
@@ -47,13 +48,94 @@ func TestProjectDuplicate(t *testing.T) {
 	err = l.Create(s, u)
 	require.NoError(t, err)
 
+	originalProjectID := l.ProjectID
+	duplicatedProjectID := l.Project.ID
+
 	// assert the new project has the same number of buckets as the old one
-	numberOfOriginalViews, err := s.Where("project_id = ?", l.ProjectID).Count(&ProjectView{})
+	numberOfOriginalViews, err := s.Where("project_id = ?", originalProjectID).Count(&ProjectView{})
 	require.NoError(t, err)
-	numberOfDuplicatedViews, err := s.Where("project_id = ?", l.Project.ID).Count(&ProjectView{})
+	numberOfDuplicatedViews, err := s.Where("project_id = ?", duplicatedProjectID).Count(&ProjectView{})
 	require.NoError(t, err)
 	assert.Equal(t, numberOfOriginalViews, numberOfDuplicatedViews, "duplicated project does not have the same amount of views as the original one")
 
-	// To make this test 100% useful, it would need to assert a lot more stuff, but it is good enough for now.
-	// Also, we're lacking utility functions to do all needed assertions.
+	// Check that the duplicated project has the same number of tasks as the original
+	numberOfOriginalTasks, err := s.Where("project_id = ?", originalProjectID).Count(&Task{})
+	require.NoError(t, err)
+	numberOfDuplicatedTasks, err := s.Where("project_id = ?", duplicatedProjectID).Count(&Task{})
+	require.NoError(t, err)
+	assert.Equal(t, numberOfOriginalTasks, numberOfDuplicatedTasks, "duplicated project does not have the same amount of tasks as the original one")
+
+	// Check that each view has the same number of task positions between original and duplicated project
+	var originalViews []*ProjectView
+	err = s.Where("project_id = ?", originalProjectID).Find(&originalViews)
+	require.NoError(t, err)
+
+	var duplicatedViews []*ProjectView
+	err = s.Where("project_id = ?", duplicatedProjectID).Find(&duplicatedViews)
+	require.NoError(t, err)
+
+	// Create a map of original view positions to compare with duplicated views
+	originalViewPositions := make(map[int64]int64)
+	for _, view := range originalViews {
+		count, err := s.Where("project_view_id = ?", view.ID).Count(&TaskPosition{})
+		require.NoError(t, err)
+		originalViewPositions[view.ID] = count
+	}
+
+	// For each duplicated view, check if it has the same number of task positions as its original counterpart
+	for i, view := range duplicatedViews {
+		taskPositionsCount, err := s.Where("project_view_id = ?", view.ID).Count(&TaskPosition{})
+		require.NoError(t, err)
+		assert.Equal(
+			t,
+			originalViewPositions[originalViews[i].ID],
+			taskPositionsCount,
+			fmt.Sprintf("duplicated view %s does not have the same amount of task positions as the original view", view.Title),
+		)
+	}
+
+	// Check that each view has the same number of task buckets between original and duplicated project
+	originalViewBuckets := make(map[int64]int64)
+	for _, view := range originalViews {
+		count, err := s.Where("project_view_id = ?", view.ID).Count(&TaskBucket{})
+		require.NoError(t, err)
+		originalViewBuckets[view.ID] = count
+	}
+
+	// For each duplicated view, check if it has the same number of task buckets as its original counterpart
+	for i, view := range duplicatedViews {
+		taskBucketsCount, err := s.Where("project_view_id = ?", view.ID).Count(&TaskBucket{})
+		require.NoError(t, err)
+		assert.Equal(
+			t,
+			originalViewBuckets[originalViews[i].ID],
+			taskBucketsCount,
+			fmt.Sprintf("duplicated view %s does not have the same amount of task buckets as the original view", view.Title),
+		)
+	}
+
+	// Check that the kanban view in the duplicated project has a different default bucket than the original
+	var originalKanbanView *ProjectView
+	var duplicatedKanbanView *ProjectView
+
+	for _, view := range originalViews {
+		if view.ViewKind == ProjectViewKindKanban {
+			originalKanbanView = view
+			break
+		}
+	}
+
+	for _, view := range duplicatedViews {
+		if view.ViewKind == ProjectViewKindKanban {
+			duplicatedKanbanView = view
+			break
+		}
+	}
+
+	require.NotNil(t, originalKanbanView, "Original project does not have a kanban view")
+	require.NotNil(t, duplicatedKanbanView, "Duplicated project does not have a kanban view")
+
+	if originalKanbanView != nil && duplicatedKanbanView != nil {
+		assert.NotEqual(t, originalKanbanView.DefaultBucketID, duplicatedKanbanView.DefaultBucketID)
+	}
 }