From 81f85a3849146d17c00a916312862af5be169e1e Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Sat, 22 Nov 2025 16:00:41 +0100
Subject: [PATCH] fix(components): add generic constraints and null checks in
 AutocompleteDropdown

- Add 'extends string' constraint to generic type T
- Add null check for model.value with nullish coalescing
- Add null check for scroller before accessing properties
- Add instanceof check for HTMLElement before accessing offsetTop
---
 .../src/components/input/AutocompleteDropdown.vue  | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/frontend/src/components/input/AutocompleteDropdown.vue b/frontend/src/components/input/AutocompleteDropdown.vue
index 8d2dc5bf5..34c132e40 100644
--- a/frontend/src/components/input/AutocompleteDropdown.vue
+++ b/frontend/src/components/input/AutocompleteDropdown.vue
@@ -1,4 +1,4 @@
-<script setup lang="ts" generic="T">
+<script setup lang="ts" generic="T extends string">
 import {type ComponentPublicInstance, nextTick, ref, watch} from 'vue'
 
 const props = withDefaults(defineProps<{
@@ -30,15 +30,21 @@ const editorRef = ref<HTMLTextAreaElement | null>(null)
 watch(
 	() => model.value,
 	newValue => {
-		val.value = newValue
+		val.value = newValue ?? ''
 	},
 )
 
 function updateSuggestionScroll() {
 	nextTick(() => {
 		const scroller = suggestionScrollerRef.value
-		const selectedItem = scroller?.querySelector('.selected')
-		scroller.scrollTop = selectedItem ? selectedItem.offsetTop : 0
+		if (!scroller) return
+
+		const selectedItem = scroller.querySelector('.selected')
+		if (selectedItem && selectedItem instanceof HTMLElement) {
+			scroller.scrollTop = selectedItem.offsetTop
+		} else {
+			scroller.scrollTop = 0
+		}
 	})
 }