From 8dbff21834e06d572abae52abf1cf09f66ebb959 Mon Sep 17 00:00:00 2001 From: John Starich Date: Sun, 8 Feb 2026 21:52:50 -0600 Subject: [PATCH] fix: add missing error checks in filepath.Walk and defer Close locations --- magefile.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/magefile.go b/magefile.go index e4303d44f..f8ed2c1ad 100644 --- a/magefile.go +++ b/magefile.go @@ -304,16 +304,16 @@ func copyFile(src, dst string) error { // Source: https://gist.github.com/var23rav/23ae5d0d4d830aff886c3c970b8f6c6b func moveFile(src, dst string) error { inputFile, err := os.Open(src) - defer inputFile.Close() if err != nil { return fmt.Errorf("couldn't open source file: %s", err) } + defer inputFile.Close() outputFile, err := os.Create(dst) - defer outputFile.Close() if err != nil { return fmt.Errorf("couldn't open dest file: %s", err) } + defer outputFile.Close() _, err = io.Copy(outputFile, inputFile) if err != nil { @@ -864,6 +864,9 @@ func (Release) Copy() error { func (Release) Check() error { p := "./" + DIST + "/release/" return filepath.Walk(p, func(path string, info os.FileInfo, err error) error { + if err != nil { + return err + } if info.IsDir() { return nil } @@ -931,6 +934,9 @@ func (Release) OsPackage() error { func (Release) Zip() error { p := "./" + DIST + "/release/" if err := filepath.Walk(p, func(path string, info os.FileInfo, err error) error { + if err != nil { + return err + } if !info.IsDir() || info.Name() == "release" { return nil } @@ -1075,10 +1081,10 @@ func init() { ` filename := "./pkg/migration/" + date + ".go" f, err := os.Create(filename) - defer f.Close() if err != nil { return err } + defer f.Close() if _, err := f.WriteString(migration); err != nil { return err