From 9eb5c62b0122e4ab0f8e5d12480b248712ebf64e Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Wed, 18 Dec 2024 21:27:01 +0100
Subject: [PATCH] fix: do not fail to load projects without views via link
 share

Resolves https://community.vikunja.io/t/undefined-error-when-sharing-an-empty-project/3126
---
 .../src/components/sharing/LinkSharing.vue    | 23 ++++++++-----------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/frontend/src/components/sharing/LinkSharing.vue b/frontend/src/components/sharing/LinkSharing.vue
index 5b4e9236b..c8dd39ebd 100644
--- a/frontend/src/components/sharing/LinkSharing.vue
+++ b/frontend/src/components/sharing/LinkSharing.vue
@@ -94,13 +94,15 @@
 			</div>
 
 			<table
-				v-if="linkShares.length > 0 && availableViews.length > 0"
+				v-if="linkShares.length > 0"
 				class="table has-actions is-striped is-hoverable is-fullwidth"
 			>
 				<thead>
 					<tr>
 						<th />
-						<th>{{ $t('project.share.links.view') }}</th>
+						<th v-if="availableViews.length > 0">
+							{{ $t('project.share.links.view') }}
+						</th>
 						<th>{{ $t('project.share.attributes.delete') }}</th>
 					</tr>
 				</thead>
@@ -169,7 +171,7 @@
 								</div>
 							</div>
 						</td>
-						<td>
+						<td v-if="availableViews.length > 0">
 							<div class="select">
 								<select v-model="selectedViews[s.id]">
 									<option
@@ -284,7 +286,7 @@ watch(() => ([linkShares.value, availableViews.value]), ([newLinkShares, newProj
 	}
 
 	newLinkShares.forEach((linkShare) => {
-		selectedViews.value[linkShare.id] = newProjectViews[0].id
+		selectedViews.value[linkShare.id] = newProjectViews.length > 0 ? newProjectViews[0].id : null
 	})
 }, {
 	immediate:true,
@@ -321,18 +323,13 @@ async function remove(projectId: IProject['id']) {
 	}
 }
 
-function getShareLink(hash: string, viewId: IProjectView['id']) {
-	return frontendUrl.value + 'share/' + hash + '/auth?view=' + viewId
+function getShareLink(hash: string, viewId: IProjectView['id']|null) {
+	return frontendUrl.value + 'share/' + hash + '/auth' + (viewId ? '?view=' + viewId : '')
 }
 
 const shareLinks = computed(() => {
-	const hasViews = Object.keys(selectedViews.value)?.length
-
 	return linkShares.value.reduce((links, linkShare) => {
-			if (!hasViews) {
-				return links
-			}
-			links[linkShare.id] = getShareLink(linkShare.hash, selectedViews.value[linkShare.id])
+			links[linkShare.id] = getShareLink(linkShare.hash, selectedViews.value[linkShare.id] ?? null)
 			return links
 		}, {} as {[id: string]: string },
 	)
@@ -344,4 +341,4 @@ const shareLinks = computed(() => {
 .sharables-project:not(.card-content) {
 	overflow-y: auto
 }
-</style>
\ No newline at end of file
+</style>