From a0478a0d96befef4583fdf10ac7a02eff4d8e435 Mon Sep 17 00:00:00 2001 From: kolaente Date: Mon, 23 Mar 2026 16:57:09 +0100 Subject: [PATCH] fix: correct error message assertion in linkshare ReadAll tests The ErrGenericForbidden HTTP message is "You're not allowed to do this.", not "Forbidden". Match on "not allowed" instead. --- pkg/webtests/link_sharing_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/webtests/link_sharing_test.go b/pkg/webtests/link_sharing_test.go index ec2f55219..f18465acc 100644 --- a/pkg/webtests/link_sharing_test.go +++ b/pkg/webtests/link_sharing_test.go @@ -741,17 +741,17 @@ func TestLinkSharing(t *testing.T) { t.Run("Shared readonly", func(t *testing.T) { _, err := testHandlerLinkShareReadOnly.testReadAllWithLinkShare(nil, map[string]string{"project": "1"}) require.Error(t, err) - assert.Contains(t, getHTTPErrorMessage(err), `Forbidden`) + assert.Contains(t, getHTTPErrorMessage(err), `not allowed`) }) t.Run("Shared write", func(t *testing.T) { _, err := testHandlerLinkShareWrite.testReadAllWithLinkShare(nil, map[string]string{"project": "2"}) require.Error(t, err) - assert.Contains(t, getHTTPErrorMessage(err), `Forbidden`) + assert.Contains(t, getHTTPErrorMessage(err), `not allowed`) }) t.Run("Shared admin", func(t *testing.T) { _, err := testHandlerLinkShareAdmin.testReadAllWithLinkShare(nil, map[string]string{"project": "3"}) require.Error(t, err) - assert.Contains(t, getHTTPErrorMessage(err), `Forbidden`) + assert.Contains(t, getHTTPErrorMessage(err), `not allowed`) }) }) t.Run("Create", func(t *testing.T) {