From c6c18d1ca1ab64af1912bf13e1ffdca226ef0551 Mon Sep 17 00:00:00 2001 From: kolaente Date: Thu, 26 Jun 2025 22:05:04 +0200 Subject: [PATCH] fix(task): ambiguous description search (#1032) test: relocate search regression --- .../task_collection_subtasks_move_test.go | 18 ++++++++++++++++++ pkg/models/task_search.go | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/pkg/models/task_collection_subtasks_move_test.go b/pkg/models/task_collection_subtasks_move_test.go index 0b30bb469..68a919439 100644 --- a/pkg/models/task_collection_subtasks_move_test.go +++ b/pkg/models/task_collection_subtasks_move_test.go @@ -78,3 +78,21 @@ func TestTaskCollection_SubtaskRemainsAfterMove(t *testing.T) { } assert.True(t, found, "subtask should be returned after moving to another project") } + +func TestTaskSearchWithExpandSubtasks(t *testing.T) { + db.LoadAndAssertFixtures(t) + s := db.NewSession() + defer s.Close() + + project, err := GetProjectSimpleByID(s, 36) + require.NoError(t, err) + + opts := &taskSearchOptions{ + search: "Caldav", + expand: []TaskCollectionExpandable{TaskCollectionExpandSubtasks}, + } + + tasks, _, _, err := getRawTasksForProjects(s, []*Project{project}, &user.User{ID: 15}, opts) + require.NoError(t, err) + require.NotEmpty(t, tasks) +} diff --git a/pkg/models/task_search.go b/pkg/models/task_search.go index 635a21a3d..029149cb5 100644 --- a/pkg/models/task_search.go +++ b/pkg/models/task_search.go @@ -283,7 +283,7 @@ func (d *dbTaskSearcher) Search(opts *taskSearchOptions) (tasks []*Task, totalCo where = builder.Or( db.ILIKE("tasks.title", opts.search), - db.ILIKE("description", opts.search), + db.ILIKE("tasks.description", opts.search), ) searchIndex := getTaskIndexFromSearchString(opts.search)