kodev-org
/
vikunja
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(api/v2): port full v1 TaskDuplicate coverage 

Assert the specific domain error code (ErrCodeTaskDoesNotExist) on the
nonexistent-source-task case, matching v1's TestTaskDuplicate. v2 carries
the code as the numeric `code` field of the RFC 9457 problem+json body,
so the test now checks that field instead of only the 404 status.
This commit is contained in:
kolaente 2026-06-03 21:14:43 +02:00 committed by kolaente
parent c9f8b87263
commit d604d8d443
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/webtests/huma_task_duplicate_test.go
View File

@ -18,9 +18,12 @@ package webtests
import (
"encoding/json"
"fmt"
"net/http"
"testing"
"code.vikunja.io/api/pkg/models"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
@ -60,6 +63,12 @@ func TestTaskDuplicateV2(t *testing.T) {
rec := humaRequest(t, e, http.MethodPost, "/api/v2/tasks/99999/duplicate", `{}`, token, "")
// Missing source task yields ErrTaskDoesNotExist (404), not the 403 of the permission cases below.
require.Equal(t, http.StatusNotFound, rec.Code, "body: %s", rec.Body.String())
// v1's TestTaskDuplicate asserts the specific domain error code
// (ErrCodeTaskDoesNotExist) here. v2 carries that code as the numeric
// `code` field of the RFC 9457 problem+json body, so assert on it to
// keep 1:1 parity with v1 rather than only checking the 404 status.
assert.Contains(t, rec.Body.String(), fmt.Sprintf(`"code":%d`, models.ErrCodeTaskDoesNotExist), "body must surface ErrCodeTaskDoesNotExist; body: %s", rec.Body.String())
})
t.Run("no read on source task is forbidden", func(t *testing.T) {