From e7f5142e3d890b4c63d5e48d896f9f713e824f5b Mon Sep 17 00:00:00 2001 From: kolaente Date: Tue, 17 Jun 2025 11:51:16 +0200 Subject: [PATCH] fix: adjust benchmark so that it only checks the task fetching --- pkg/models/task_search_bench_test.go | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/pkg/models/task_search_bench_test.go b/pkg/models/task_search_bench_test.go index 1027b39eb..9031e902a 100644 --- a/pkg/models/task_search_bench_test.go +++ b/pkg/models/task_search_bench_test.go @@ -123,9 +123,28 @@ func BenchmarkTaskSearch(b *testing.B) { } } - tc := &TaskCollection{ - Filter: "done = false", - FilterTimezone: "UTC", + // Get all projects for the user + s := db.NewSession() + projects, _, _, err := getRawProjectsForUser( + s, + &projectOptions{ + user: auth, + page: -1, + }, + ) + s.Close() + if err != nil { + b.Fatalf("get projects: %v", err) + } + + // Create search options + opts := &taskSearchOptions{ + search: needle, + page: 1, + perPage: 50, + filter: "done = false", + filterTimezone: "UTC", + filterIncludeNulls: false, } b.Log("Setup done, starting benchmark...") @@ -133,8 +152,7 @@ func BenchmarkTaskSearch(b *testing.B) { b.ResetTimer() for i := 0; i < b.N; i++ { s := db.NewSession() - result, _, _, err := tc.ReadAll(s, auth, needle, 1, 50) - resultSlice := result.([]*Task) + resultSlice, _, _, err := getRawTasksForProjects(s, projects, auth, opts) if len(resultSlice) == 0 { b.Fatalf("no results found for needle %q", needle) }