From fa032a889f4dfe8c7c6cf683272979e2c70d9c35 Mon Sep 17 00:00:00 2001 From: kolaente Date: Mon, 28 Oct 2024 16:16:48 +0100 Subject: [PATCH] fix(filters): do not crash when a filter is invalid Resolves https://vikunja.sentry.io/issues/6025547266/events/a62beaa09caf482ba238b18f363956df --- pkg/models/listeners.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pkg/models/listeners.go b/pkg/models/listeners.go index 1da6bc0d9..4da2536af 100644 --- a/pkg/models/listeners.go +++ b/pkg/models/listeners.go @@ -692,6 +692,14 @@ func (l *UpdateTaskInSavedFilterViews) Handle(msg *message.Message) (err error) taskBucket, taskPosition, err := addTaskToFilter(s, filter, view, doerTimezone, event.Task) if err != nil { + if IsErrInvalidFilterExpression(err) || + IsErrInvalidTaskFilterValue(err) || + IsErrInvalidTaskFilterConcatinator(err) || + IsErrInvalidTaskFilterComparator(err) { + log.Debugf("Invalid filter expression for view %d, expression: %s", view.ID, view.Filter) + continue + } + return err }