From fcc204dc883aa8422e69a25fd1a94cfaed1aa61c Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 11 Sep 2025 22:39:16 +0200
Subject: [PATCH] fix(link share): add better error handling, ensure projects
 are shown  (#1481)

---
 .../src/components/home/ContentLinkShare.vue  | 123 ++++++++++++++++--
 frontend/src/i18n/lang/en.json                |   6 +-
 frontend/src/stores/projects.ts               |  19 +++
 .../src/views/sharing/LinkSharingAuth.vue     |  17 +++
 4 files changed, 155 insertions(+), 10 deletions(-)

diff --git a/frontend/src/components/home/ContentLinkShare.vue b/frontend/src/components/home/ContentLinkShare.vue
index 47ed0a1bb..1146bf6be 100644
--- a/frontend/src/components/home/ContentLinkShare.vue
+++ b/frontend/src/components/home/ContentLinkShare.vue
@@ -12,12 +12,37 @@
 				v-if="logoVisible"
 				class="logo"
 			/>
-			<h1
+			<Message
+				v-if="projectLoadError"
+				variant="danger"
+				class="mbe-4"
+			>
+				{{ $t('sharing.projectLoadError') }}
+				<BaseButton
+					variant="secondary"
+					class="mls-2"
+					@click="retryProjectLoad"
+				>
+					{{ $t('sharing.retry') }}
+				</BaseButton>
+			</Message>
+			<BaseButton
+				v-if="!projectLoadError && currentProject"
+				:to="getProjectRoute()"
+				variant="text"
+				class="project-title-button"
+				:class="{'m-0': !logoVisible}"
+			>
+				<h1 class="title clickable-title">
+					{{ currentProject?.title === '' ? $t('misc.loading') : currentProject?.title }}
+				</h1>
+			</BaseButton>
+			<h1
+				v-else-if="!projectLoadError"
 				:class="{'m-0': !logoVisible}"
-				:style="{ 'opacity': currentProject?.title === '' ? '0': '1' }"
 				class="title"
 			>
-				{{ currentProject?.title === '' ? $t('misc.loading') : currentProject?.title }}
+				{{ $t('misc.loading') }}
 			</h1>
 			<div class="box has-text-start view">
 				<RouterView />
@@ -28,29 +53,88 @@
 </template>
 
 <script lang="ts" setup>
-import {computed} from 'vue'
+import {computed, ref, watch, onMounted} from 'vue'
+import {useRoute} from 'vue-router'
 
 import {useBaseStore} from '@/stores/base'
-import {useRoute} from 'vue-router'
+import {useProjectStore} from '@/stores/projects'
+import {useLabelStore} from '@/stores/labels'
+import {useAuthStore} from '@/stores/auth'
 
 import Logo from '@/components/home/Logo.vue'
 import PoweredByLink from './PoweredByLink.vue'
-import {useProjectStore} from '@/stores/projects'
-import {useLabelStore} from '@/stores/labels'
+import BaseButton from '@/components/base/BaseButton.vue'
+import Message from '@/components/misc/Message.vue'
 import {PROJECT_VIEW_KINDS} from '@/modelTypes/IProjectView'
 
 const baseStore = useBaseStore()
+const projectStore = useProjectStore()
+const authStore = useAuthStore()
+const route = useRoute()
+
 const currentProject = computed(() => baseStore.currentProject)
 const background = computed(() => baseStore.background)
 const logoVisible = computed(() => baseStore.logoVisible)
+const projectLoadError = ref(false)
 
-const projectStore = useProjectStore()
 projectStore.loadAllProjects()
 
 const labelStore = useLabelStore()
 labelStore.loadAllLabels()
 
-const route = useRoute()
+// Ensure project is loaded for link share
+async function ensureProjectLoaded() {
+	if (!authStore.authLinkShare || !route.params.projectId) {
+		return
+	}
+	
+	try {
+		projectLoadError.value = false
+		
+		// Load project if not already loaded
+		const projectId = Number(route.params.projectId)
+		if (!currentProject.value || currentProject.value.id !== projectId) {
+			await projectStore.loadProject(projectId)
+		}
+	} catch (e) {
+		console.error('Failed to load project for link share:', e)
+		projectLoadError.value = true
+	}
+}
+
+async function retryProjectLoad() {
+	await ensureProjectLoaded()
+}
+
+// Watch for route changes and ensure project is loaded
+watch(() => route.params.projectId, ensureProjectLoaded, { immediate: true })
+
+onMounted(ensureProjectLoaded)
+
+function getProjectRoute() {
+	if (!currentProject.value) return null
+	
+	const hash = route.hash // Preserve link share hash
+	
+	// Default to the first available view or list view
+	const projectId = currentProject.value.id
+	const firstView = projectStore.projects[projectId]?.views?.[0]
+	
+	if (firstView) {
+		return {
+			name: 'project.view',
+			params: { projectId, viewId: firstView.id },
+			hash,
+		}
+	}
+	
+	return {
+		name: 'project.index', 
+		params: { projectId },
+		hash,
+	}
+}
+
 const isFullWidth = computed(() => {
 	const viewId = route.params?.viewId ?? null
 	const projectId = route.params?.projectId ?? null
@@ -82,6 +166,27 @@ const isFullWidth = computed(() => {
 	text-shadow: 0 0 1rem var(--white);
 }
 
+.project-title-button {
+	background: none !important;
+	border: none !important;
+	padding: 0 !important;
+	text-decoration: none !important;
+	
+	&:hover .clickable-title {
+		opacity: 0.8;
+		cursor: pointer;
+	}
+}
+
+.clickable-title {
+	text-shadow: 0 0 1rem var(--white);
+	margin: 0;
+	
+	&:hover {
+		text-decoration: underline;
+	}
+}
+
 .link-share-view {
 	inline-size: 100%;
 	max-inline-size: $desktop;
diff --git a/frontend/src/i18n/lang/en.json b/frontend/src/i18n/lang/en.json
index 400942c70..585915cc9 100644
--- a/frontend/src/i18n/lang/en.json
+++ b/frontend/src/i18n/lang/en.json
@@ -588,7 +588,11 @@
     "authenticating": "Authenticating…",
     "passwordRequired": "This shared project requires a password. Please enter it below:",
     "error": "An error occurred.",
-    "invalidPassword": "The password is invalid."
+    "invalidPassword": "The password is invalid.",
+    "accessDenied": "Access denied. Please check your permissions and try again.",
+    "serverError": "Server error occurred. Please try again later.",
+    "projectLoadError": "Failed to load project information.",
+    "retry": "Retry"
   },
   "navigation": {
     "overview": "Overview",
diff --git a/frontend/src/stores/projects.ts b/frontend/src/stores/projects.ts
index 9ee06244a..00f82f01a 100644
--- a/frontend/src/stores/projects.ts
+++ b/frontend/src/stores/projects.ts
@@ -255,6 +255,24 @@ export const useProjectStore = defineStore('project', () => {
 			views: updatedViews,
 		})
 	}
+
+	// Add method to ensure single project loading works for link shares
+	async function loadProject(projectId: number) {
+		const project = projects.value[projectId]
+		if (project) {
+			return project
+		}
+
+		try {
+			const projectService = new ProjectService()
+			const loadedProject = await projectService.get({id: projectId})
+			setProject(loadedProject)
+			return loadedProject
+		} catch (e) {
+			console.error(`Failed to load project ${projectId}:`, e)
+			throw e
+		}
+	}
 	
 	return {
 		isLoading: readonly(isLoading),
@@ -277,6 +295,7 @@ export const useProjectStore = defineStore('project', () => {
 		removeProjectById,
 		toggleProjectFavorite,
 		loadAllProjects,
+		loadProject,
 		createProject,
 		updateProject,
 		deleteProject,
diff --git a/frontend/src/views/sharing/LinkSharingAuth.vue b/frontend/src/views/sharing/LinkSharingAuth.vue
index 0feef6dc9..0813004e7 100644
--- a/frontend/src/views/sharing/LinkSharingAuth.vue
+++ b/frontend/src/views/sharing/LinkSharingAuth.vue
@@ -137,6 +137,23 @@ function useAuth() {
 				return
 			}
 
+			// Handle generic 403 errors that might occur after initial auth
+			if (e?.response?.status === 403 && !e?.response?.data?.code) {
+				errorMessage.value = t('sharing.accessDenied')
+				authenticateWithPassword.value = false
+				return
+			}
+			
+			// Handle network/server errors
+			if (e?.response?.status >= 500 || !e?.response) {
+				errorMessage.value = t('sharing.serverError')
+				authenticateWithPassword.value = false
+				return
+			}
+			
+			// Log unexpected errors for debugging
+			console.error('Link share authentication error:', e)
+
 			// TODO: Put this logic in a global errorMessage handler method which checks all auth codes
 			let err = t('sharing.error')
 			if (e?.response?.data?.message) {