Commit Graph

134 Commits

Author SHA1 Message Date
DanielPantle faff1040dc feat(task): cancel editing task title with escape (#2730)
With this change, it is possible to cancel editing the task title with pressing the escape key.

# Problem

Before it was not possible to cancel editing the task title. Pressing outside the title saves the changes that have already been done (which is intended I think). But when e.g. pasting something with a wrong format, I was not able to revert the change without saving and editing it again

Example: after accidentially pasting something with multiple lines it is not possible to escape, the only way to revert this is to save and edit again manually:
![grafik.png](/attachments/11d3559a-3111-458f-9a9c-4107292054fa)

# Solution

This PR implements a listener for the escape key that sets the title back to its original value and blurs the focus of the title

# Additional notes

- I checked this in the "page" view of the task and the "popup" view and it worked in both. For me, the popup does not close with the escape key (as it often does on other sites), therefore there is no collision with this function. But I think it would be good to check this again to make sure it does not break anything like this
- I don't know anything about testing in this repository, if it is possible/necessary to implement a test for this feature please leave a comment :)

Co-authored-by: Daniel Pantle <daniel.pantle@newtec.de>
Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2730
Co-authored-by: DanielPantle <danielpantle@noreply.kolaente.dev>
Co-committed-by: DanielPantle <danielpantle@noreply.kolaente.dev>
2024-10-02 07:32:33 +00:00
kolaente 308e634c71
fix(task): do not show close button when the task was not opened via modal 2024-09-29 13:36:30 +02:00
kolaente 54994a1671
fix(task): paginate task comments
Resolves https://github.com/go-vikunja/vikunja/issues/329
2024-09-29 13:28:29 +02:00
kolaente a7bd9dad24
feat(task): use focus-visible for task focus styles 2024-09-19 13:01:18 +02:00
kolaente 10e245f6d0
fix(a11y): hide unfocusable buttons 2024-09-19 12:50:47 +02:00
kolaente 010dd1ea22
fix(task): open focused task when pressing enter 2024-09-19 12:50:21 +02:00
kolaente 65a2814b2a
feat(navigation): use focus-visible for nav items 2024-09-19 12:36:33 +02:00
kolaente ec902b051b
fix(task): mark related task as done from the task detail view
Resolves https://github.com/go-vikunja/vikunja/issues/326
2024-09-19 11:31:06 +02:00
kolaente abf92e29fa fix(task): dragging and dropping on mobile
This change fixes a regression introduced in 1cbb93ea9b.
In that change, the whole task area was made clickable using mouse events directly. Unfortunately, this also prevented the parent component of the task component to recieve them, essentially never getting notified about the mouse movement and thus never dragging the task. I don't know why this is only a problem on Safari, but it might be related to https://github.com/SortableJS/Sortable/issues/1571#issuecomment-535684451

Resolves https://community.vikunja.io/t/task-re-ordering-is-not-working-in-safari/1916
Resolves https://kolaente.dev/vikunja/vikunja/issues/2092
Resolves https://github.com/go-vikunja/vikunja/issues/304
2024-09-18 18:00:27 +02:00
kolaente cc64ca6406
fix(task): align task title on mobile popup 2024-09-18 11:36:06 +02:00
kolaente 4c55016c1a
fix(task): multiple overlapping defer due date popups
Resolves https://github.com/go-vikunja/vikunja/issues/131
2024-09-13 17:44:26 +02:00
kolaente bdccd633fe
fix(labels): remove input interactivity when label edit is disabled 2024-09-12 13:39:03 +02:00
kolaente 76f7797e56
chore: remove console.log 2024-09-11 18:14:10 +02:00
kolaente 55dd7d2981
fix(task): specify task index when creating multiple tasks at once
This change allows to specify the task index when creating a task, which will then be checked to avoid duplicates and used. This allows us to calculate the indexes for all tasks beforehand when creating them at once using quick add magic.
The method is not bulletproof, but already fixes a problem where multiple tasks would have the same index when created that way.

Resolves https://community.vikunja.io/t/add-multiple-tasks-at-once/333/16
2024-09-11 17:58:42 +02:00
kolaente 02c1de55c4
chore(attachments): refactor building image preview 2024-09-06 09:43:59 +02:00
kolaente f22420d502
fix(kanban): always make cover image full width 2024-08-12 17:22:26 +02:00
kolaente 7efc4d1bc8
fix(task): do not allow moving a task to the project the task already belongs to 2024-08-12 15:18:45 +02:00
Elscrux 75ce261f74 feat: downscaled image previews for task attachments (#2541)
As discussed in [https://community.vikunja.io/t/add-scaled-down-images-for-image-previews](https://community.vikunja.io/t/add-scaled-down-images-for-image-previews) this adds a query parameter in the task attachment request which returns a scaled down image for preview purposes to reduce network load and improve responsiveness.

Co-authored-by: Elscrux <nickposer2102@gmail.com>
Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2541
Reviewed-by: konrad <k@knt.li>
Co-authored-by: Elscrux <elscrux@gmail.com>
Co-committed-by: Elscrux <elscrux@gmail.com>
2024-07-19 09:30:06 +00:00
devadattas 5f9d0fe763 feat: permalinks for task comments (#2442)
Resolves #2441

Co-authored-by: Devadatta Sahoo <webmaster@nettantra.com>
Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2442
Reviewed-by: konrad <k@knt.li>
Co-authored-by: devadattas <devadattas@gmail.com>
Co-committed-by: devadattas <devadattas@gmail.com>
2024-07-19 08:45:50 +00:00
Dominik Pschenitschni d35454c099 feat: improve priority visibility 2024-07-19 06:53:53 +00:00
Dominik Pschenitschni 6990be705c
feat: use withDefaults for Reminders 2024-07-18 18:31:33 +02:00
Dominik Pschenitschni f1481d702c feat: withDefaults for EditAssignees 2024-07-17 10:33:28 +00:00
Dominik Pschenitschni c8585d1a69 feat: use withDefaults for RepeatAfter 2024-07-17 06:46:47 +00:00
Dominik Pschenitschni aaa2abced4 feat: add withDefaults and emit types to PrioritySelect 2024-07-17 02:33:35 +00:00
Dominik Pschenitschni ddc18aa177 feat: remove props destructuring from KanbanCard 2024-07-16 23:28:15 +00:00
Dominik Pschenitschni 07130bdc3a feat: remove props destructuring from Attachments 2024-07-16 23:10:57 +00:00
Dominik Pschenitschni 6e72606d74 feat: use withDefaults for EditLabels 2024-07-16 22:09:37 +00:00
Dominik Pschenitschni a15831eb33 feat: remove props destructuring from SingleTaskInProject 2024-07-16 22:04:17 +00:00
Dominik Pschenitschni 871e0acd8a feat: use withDefaults for PriorityLabel 2024-07-16 21:58:07 +00:00
Dominik Pschenitschni fd3f1de861 feat: type defineEmits for Heading 2024-07-16 21:50:32 +00:00
Dominik Pschenitschni f38a5c9220 feat: type defineEmits for ProjectSearch 2024-07-16 21:50:27 +00:00
Dominik Pschenitschni 8ac0eb4aa4 feat: defineModel and withDefaults for PercentDoneSelect 2024-07-16 21:49:02 +00:00
Dominik Pschenitschni 46aa2fff0f feat: remove props destructuring for DeferTask 2024-07-16 21:43:36 +00:00
Dominik Pschenitschni 0bc1832050 feat: remove PropTypes helper from FilePreview 2024-07-16 21:39:15 +00:00
Dominik Pschenitschni f19f19bb75 feat: use withDefaults for Comments 2024-07-16 21:37:52 +00:00
Dominik Pschenitschni 4b9b9da122 feat: use withDefaults for ReminderPeriod 2024-07-16 21:35:06 +00:00
Dominik Pschenitschni f586e51aad feat: use withDefaults for DateTableCell 2024-07-16 21:32:06 +00:00
Dominik Pschenitschni a56331d39d feat: use withDefaults in ReminderDetail 2024-07-05 15:34:12 +00:00
Dominik Pschenitschni 42c458a736
feat: simplify playPopSound setting check 2024-07-05 14:24:53 +02:00
Dominik Pschenitschni 5cf57a520c feat: use withDefaults for Heading 2024-07-05 12:02:39 +00:00
Dominik Pschenitschni f08039b23c
fix: ProjectSearch default value 2024-07-03 10:02:31 +02:00
Dominik Pschenitschni 7db9e64053 feat: use withDefaults for AddTask 2024-06-30 14:16:01 +00:00
Dominik Pschenitschni c81649c139 feat: use defineProps types in CreatedUpdated 2024-06-28 21:10:55 +00:00
Dominik Pschenitschni dea051010d feat: use withDefaults for Labels 2024-06-28 21:08:35 +00:00
Dominik Pschenitschni 1dbd8b6c37 feat: use defineProps types for ChecklistSummary 2024-06-28 21:07:31 +00:00
Dominik Pschenitschni 7c9f0b8ada feat: remove props destructuring from SingleTaskInlineReadonly 2024-06-28 21:02:01 +00:00
Dominik Pschenitschni bd32f7aef5 feat: use withDefaults for ProjectSearch 2024-06-28 21:00:15 +00:00
Dominik Pschenitschni b224b331f5 fix: remove props prefix from template 2024-06-25 13:57:52 +00:00
Dominik Pschenitschni baaf612239
fix: import PeriodUnit as type 2024-06-20 12:16:09 +02:00
kolaente 9101f26101
fix(comments): do not use whitespace as gap 2024-06-19 16:48:21 +02:00