ci: make mysql:8 matrix leg blocking

Drop the experimental/continue-on-error gating on the mysql-8 leg so
failures are surfaced directly on the PR. We want to see any
MySQL-8-specific regressions break CI instead of hiding them behind a
soft-fail while we stabilize.

Refs #2589

.github/workflows/test.yml

@@ -101,10 +101,18 @@ jobs:
         db:
           - sqlite
           - postgres
-          - mysql
+          - mariadb
+          - mysql-8
     services:
-      migration-smoke-db-mysql:
-        image: mariadb:12@sha256:f54db0cb3ccfe9431aba6d08c65a1763c499789b116b4cb651dd7fcf325965b3
+      migration-smoke-db-mariadb:
+        image: ${{ matrix.db == 'mariadb' && 'mariadb:12@sha256:f54db0cb3ccfe9431aba6d08c65a1763c499789b116b4cb651dd7fcf325965b3' || '' }}
+        env:
+          MYSQL_ROOT_PASSWORD: vikunjatest
+          MYSQL_DATABASE: vikunjatest
+        ports:
+          - 3306:3306
+      migration-smoke-db-mysql-8:
+        image: ${{ matrix.db == 'mysql-8' && 'mysql:8@sha256:da906917ca4ace3ba55538b7c2ee97a9bc865ef14a4b6920b021f0249d603f3d' || '' }}
         env:
           MYSQL_ROOT_PASSWORD: vikunjatest
           MYSQL_DATABASE: vikunjatest
@@ -128,7 +136,7 @@ jobs:
           name: vikunja_bin
       - name: run migration
         env:
-          VIKUNJA_DATABASE_TYPE: ${{ matrix.db }}
+          VIKUNJA_DATABASE_TYPE: ${{ (matrix.db == 'mariadb' || matrix.db == 'mysql-8') && 'mysql' || matrix.db }}
           VIKUNJA_DATABASE_PATH: ./vikunja-migration-test.db
           VIKUNJA_DATABASE_USER: ${{ matrix.db == 'postgres' && 'postgres' || 'root' }}
           VIKUNJA_DATABASE_PASSWORD: vikunjatest
@@ -173,14 +181,22 @@ jobs:
           - sqlite-in-memory
           - sqlite
           - postgres
-          - mysql
+          - mariadb
+          - mysql-8
           - paradedb
         test:
           - feature
           - web
     services:
-      db-mysql:
-        image: ${{ matrix.db == 'mysql' && 'mariadb:12@sha256:5b6a1eac15b85b981a61afb89aea2a22bf76b5f58809d05f0bcc13ab6ec44cb8' || '' }}
+      db-mariadb:
+        image: ${{ matrix.db == 'mariadb' && 'mariadb:12@sha256:5b6a1eac15b85b981a61afb89aea2a22bf76b5f58809d05f0bcc13ab6ec44cb8' || '' }}
+        env:
+          MYSQL_ROOT_PASSWORD: vikunjatest
+          MYSQL_DATABASE: vikunjatest
+        ports:
+          - 3306:3306
+      db-mysql-8:
+        image: ${{ matrix.db == 'mysql-8' && 'mysql:8@sha256:da906917ca4ace3ba55538b7c2ee97a9bc865ef14a4b6920b021f0249d603f3d' || '' }}
         env:
           MYSQL_ROOT_PASSWORD: vikunjatest
           MYSQL_DATABASE: vikunjatest
@@ -226,8 +242,8 @@ jobs:
       - name: test
         env:
           VIKUNJA_TESTS_USE_CONFIG: ${{ matrix.db != 'sqlite-in-memory' && 1 || 0 }}
-          VIKUNJA_DATABASE_TYPE: ${{ matrix.db == 'paradedb' && 'postgres' || matrix.db }}
-          VIKUNJA_DATABASE_USER: ${{ matrix.db == 'mysql' && 'root' || 'postgres' }}
+          VIKUNJA_DATABASE_TYPE: ${{ (matrix.db == 'paradedb' && 'postgres') || ((matrix.db == 'mariadb' || matrix.db == 'mysql-8') && 'mysql') || matrix.db }}
+          VIKUNJA_DATABASE_USER: ${{ (matrix.db == 'mariadb' || matrix.db == 'mysql-8') && 'root' || 'postgres' }}
           VIKUNJA_DATABASE_PASSWORD: vikunjatest
           VIKUNJA_DATABASE_DATABASE: vikunjatest
           VIKUNJA_DATABASE_SSLMODE: disable