198 lines
7.8 KiB
Go
198 lines
7.8 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-present Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package webtests
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"code.vikunja.io/api/pkg/db"
|
|
"code.vikunja.io/api/pkg/modules/auth"
|
|
"code.vikunja.io/api/pkg/user"
|
|
|
|
"github.com/labstack/echo/v5"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
const (
|
|
// Token 9 has only the mcp:access scope, owned by user 1.
|
|
mcpOnlyToken = "tk_mcp_access_token_test_0000000000mcp0001"
|
|
// Token 1 has only {tasks:[read_all, update]} — no mcp scope. Owner: user 1.
|
|
// (Token 10, mcp + projects:{read_one, read_all}, is reserved for the
|
|
// scope-filtering tests that land with Task 6.)
|
|
noMCPToken = "tk_2eef46f40ebab3304919ab2e7e39993f75f29d2e"
|
|
)
|
|
|
|
// mcpRequest builds an MCP request with the appropriate Accept + Content-Type
|
|
// headers required by the streamable-HTTP transport.
|
|
func mcpRequest(method, body string) *http.Request {
|
|
req := httptest.NewRequest(method, "/api/v1/mcp", strings.NewReader(body))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
req.Header.Set("Accept", "application/json, text/event-stream")
|
|
return req
|
|
}
|
|
|
|
// readMCPJSON extracts the JSON-RPC payload from an MCP response. The SDK
|
|
// may return either application/json (single object) or a single-event SSE
|
|
// stream depending on negotiation.
|
|
func readMCPJSON(t *testing.T, body string) map[string]any {
|
|
t.Helper()
|
|
body = strings.TrimSpace(body)
|
|
// SSE framing — find the first "data: " line.
|
|
if strings.HasPrefix(body, "event:") || strings.Contains(body, "data:") {
|
|
for _, line := range strings.Split(body, "\n") {
|
|
if strings.HasPrefix(line, "data:") {
|
|
body = strings.TrimSpace(strings.TrimPrefix(line, "data:"))
|
|
break
|
|
}
|
|
}
|
|
}
|
|
var out map[string]any
|
|
require.NoError(t, json.Unmarshal([]byte(body), &out), "body was: %s", body)
|
|
return out
|
|
}
|
|
|
|
func TestMCP_AnonymousRejected(t *testing.T) {
|
|
e, err := setupTestEnv()
|
|
require.NoError(t, err)
|
|
|
|
req := mcpRequest(http.MethodPost, `{"jsonrpc":"2.0","id":1,"method":"initialize","params":{}}`)
|
|
rec := httptest.NewRecorder()
|
|
e.ServeHTTP(rec, req)
|
|
|
|
assert.Equal(t, http.StatusUnauthorized, rec.Code)
|
|
}
|
|
|
|
func TestMCP_JWTRejected(t *testing.T) {
|
|
// MCP is a token-only endpoint. JWT bypasses CanDoAPIRoute entirely, so
|
|
// without an explicit rejection the scope gate would be moot.
|
|
e, err := setupTestEnv()
|
|
require.NoError(t, err)
|
|
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
u, err := user.GetUserByID(s, 1)
|
|
require.NoError(t, err)
|
|
jwt, err := auth.NewUserJWTAuthtoken(u, "test-session-id")
|
|
require.NoError(t, err)
|
|
|
|
req := mcpRequest(http.MethodPost, `{"jsonrpc":"2.0","id":1,"method":"initialize","params":{}}`)
|
|
req.Header.Set(echo.HeaderAuthorization, "Bearer "+jwt)
|
|
rec := httptest.NewRecorder()
|
|
e.ServeHTTP(rec, req)
|
|
|
|
assert.Equal(t, http.StatusUnauthorized, rec.Code)
|
|
}
|
|
|
|
func TestMCP_TokenWithoutMCPScopeRejected(t *testing.T) {
|
|
e, err := setupTestEnv()
|
|
require.NoError(t, err)
|
|
|
|
req := mcpRequest(http.MethodPost, `{"jsonrpc":"2.0","id":1,"method":"initialize","params":{}}`)
|
|
req.Header.Set(echo.HeaderAuthorization, "Bearer "+noMCPToken)
|
|
rec := httptest.NewRecorder()
|
|
e.ServeHTTP(rec, req)
|
|
|
|
assert.Equal(t, http.StatusForbidden, rec.Code)
|
|
}
|
|
|
|
func TestMCP_InitializeWithMCPToken(t *testing.T) {
|
|
e, err := setupTestEnv()
|
|
require.NoError(t, err)
|
|
|
|
req := mcpRequest(http.MethodPost, `{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2024-11-05","capabilities":{},"clientInfo":{"name":"test","version":"0.1"}}}`)
|
|
req.Header.Set(echo.HeaderAuthorization, "Bearer "+mcpOnlyToken)
|
|
rec := httptest.NewRecorder()
|
|
e.ServeHTTP(rec, req)
|
|
|
|
require.Equal(t, http.StatusOK, rec.Code, "body: %s", rec.Body.String())
|
|
payload := readMCPJSON(t, rec.Body.String())
|
|
result, ok := payload["result"].(map[string]any)
|
|
require.True(t, ok, "response missing result: %s", rec.Body.String())
|
|
assert.NotEmpty(t, result["protocolVersion"])
|
|
serverInfo, ok := result["serverInfo"].(map[string]any)
|
|
require.True(t, ok, "response missing serverInfo: %s", rec.Body.String())
|
|
assert.Equal(t, "vikunja", serverInfo["name"])
|
|
|
|
// The SDK exposes the session ID via the Mcp-Session-Id header.
|
|
assert.NotEmpty(t, rec.Header().Get("Mcp-Session-Id"))
|
|
}
|
|
|
|
func TestMCP_ToolsListEmpty(t *testing.T) {
|
|
e, err := setupTestEnv()
|
|
require.NoError(t, err)
|
|
|
|
// Step 1: initialize so the SDK opens a session.
|
|
initReq := mcpRequest(http.MethodPost, `{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2024-11-05","capabilities":{},"clientInfo":{"name":"test","version":"0.1"}}}`)
|
|
initReq.Header.Set(echo.HeaderAuthorization, "Bearer "+mcpOnlyToken)
|
|
initRec := httptest.NewRecorder()
|
|
e.ServeHTTP(initRec, initReq)
|
|
require.Equal(t, http.StatusOK, initRec.Code, "body: %s", initRec.Body.String())
|
|
sessionID := initRec.Header().Get("Mcp-Session-Id")
|
|
require.NotEmpty(t, sessionID)
|
|
|
|
// Step 2: send the required "notifications/initialized" client message.
|
|
initNotifyReq := mcpRequest(http.MethodPost, `{"jsonrpc":"2.0","method":"notifications/initialized"}`)
|
|
initNotifyReq.Header.Set(echo.HeaderAuthorization, "Bearer "+mcpOnlyToken)
|
|
initNotifyReq.Header.Set("Mcp-Session-Id", sessionID)
|
|
initNotifyRec := httptest.NewRecorder()
|
|
e.ServeHTTP(initNotifyRec, initNotifyReq)
|
|
require.Less(t, initNotifyRec.Code, 400, "body: %s", initNotifyRec.Body.String())
|
|
|
|
// Step 3: ask for tools.
|
|
listReq := mcpRequest(http.MethodPost, `{"jsonrpc":"2.0","id":2,"method":"tools/list","params":{}}`)
|
|
listReq.Header.Set(echo.HeaderAuthorization, "Bearer "+mcpOnlyToken)
|
|
listReq.Header.Set("Mcp-Session-Id", sessionID)
|
|
listRec := httptest.NewRecorder()
|
|
e.ServeHTTP(listRec, listReq)
|
|
|
|
require.Equal(t, http.StatusOK, listRec.Code, "body: %s", listRec.Body.String())
|
|
payload := readMCPJSON(t, listRec.Body.String())
|
|
result, ok := payload["result"].(map[string]any)
|
|
require.True(t, ok, "response missing result: %s", listRec.Body.String())
|
|
tools, ok := result["tools"].([]any)
|
|
require.True(t, ok, "response missing tools array: %s", listRec.Body.String())
|
|
assert.Empty(t, tools, "expected empty tools list, got: %v", tools)
|
|
}
|
|
|
|
func TestMCP_SessionRoundTrip(t *testing.T) {
|
|
// Verifies that the Mcp-Session-Id round-trip survives the Echo wrapper.
|
|
e, err := setupTestEnv()
|
|
require.NoError(t, err)
|
|
|
|
initReq := mcpRequest(http.MethodPost, `{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2024-11-05","capabilities":{},"clientInfo":{"name":"test","version":"0.1"}}}`)
|
|
initReq.Header.Set(echo.HeaderAuthorization, "Bearer "+mcpOnlyToken)
|
|
initRec := httptest.NewRecorder()
|
|
e.ServeHTTP(initRec, initReq)
|
|
require.Equal(t, http.StatusOK, initRec.Code, "body: %s", initRec.Body.String())
|
|
sessionID := initRec.Header().Get("Mcp-Session-Id")
|
|
require.NotEmpty(t, sessionID)
|
|
|
|
// A follow-up request with a known session id should be accepted (not
|
|
// rejected as "session not found").
|
|
pingReq := mcpRequest(http.MethodPost, `{"jsonrpc":"2.0","id":99,"method":"ping","params":{}}`)
|
|
pingReq.Header.Set(echo.HeaderAuthorization, "Bearer "+mcpOnlyToken)
|
|
pingReq.Header.Set("Mcp-Session-Id", sessionID)
|
|
pingRec := httptest.NewRecorder()
|
|
e.ServeHTTP(pingRec, pingReq)
|
|
require.Equal(t, http.StatusOK, pingRec.Code, "body: %s", pingRec.Body.String())
|
|
}
|