kodev-org
/
vikunja
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: add missing error checks in filepath.Walk and defer Close locations

This commit is contained in:
John Starich 2026-02-08 21:52:50 -06:00 committed by kolaente
parent e19a61479e
commit 8dbff21834
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
magefile.go
View File

@ -304,16 +304,16 @@ func copyFile(src, dst string) error {
// Source: https://gist.github.com/var23rav/23ae5d0d4d830aff886c3c970b8f6c6b // Source: https://gist.github.com/var23rav/23ae5d0d4d830aff886c3c970b8f6c6b
func moveFile(src, dst string) error { func moveFile(src, dst string) error {
inputFile, err := os.Open(src) inputFile, err := os.Open(src)
defer inputFile.Close()
if err != nil { if err != nil {
return fmt.Errorf("couldn't open source file: %s", err) return fmt.Errorf("couldn't open source file: %s", err)
} }
defer inputFile.Close()
outputFile, err := os.Create(dst) outputFile, err := os.Create(dst)
defer outputFile.Close()
if err != nil { if err != nil {
return fmt.Errorf("couldn't open dest file: %s", err) return fmt.Errorf("couldn't open dest file: %s", err)
} }
defer outputFile.Close()
_, err = io.Copy(outputFile, inputFile) _, err = io.Copy(outputFile, inputFile)
if err != nil { if err != nil {
@ -864,6 +864,9 @@ func (Release) Copy() error {
func (Release) Check() error { func (Release) Check() error {
p := "./" + DIST + "/release/" p := "./" + DIST + "/release/"
return filepath.Walk(p, func(path string, info os.FileInfo, err error) error { return filepath.Walk(p, func(path string, info os.FileInfo, err error) error {
if err != nil {
return err
}
if info.IsDir() { if info.IsDir() {
return nil return nil
} }
@ -931,6 +934,9 @@ func (Release) OsPackage() error {
func (Release) Zip() error { func (Release) Zip() error {
p := "./" + DIST + "/release/" p := "./" + DIST + "/release/"
if err := filepath.Walk(p, func(path string, info os.FileInfo, err error) error { if err := filepath.Walk(p, func(path string, info os.FileInfo, err error) error {
if err != nil {
return err
}
if !info.IsDir() || info.Name() == "release" { if !info.IsDir() || info.Name() == "release" {
return nil return nil
} }
@ -1075,10 +1081,10 @@ func init() {
` `
filename := "./pkg/migration/" + date + ".go" filename := "./pkg/migration/" + date + ".go"
f, err := os.Create(filename) f, err := os.Create(filename)
defer f.Close()
if err != nil { if err != nil {
return err return err
} }
defer f.Close()
if _, err := f.WriteString(migration); err != nil { if _, err := f.WriteString(migration); err != nil {
return err return err